[ 
https://issues.apache.org/jira/browse/HBASE-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506850#comment-13506850
 ] 

Sergey Shelukhin commented on HBASE-7055:
-----------------------------------------

It doesn't read CF values directly, what it does as encapsulate the logic such 
as runtime-based defaults (e.g. memstore flush size for min compaction size, 
throttling default, etc.) and some validation. 
This logic was already there, now it's just in separate class.
For tiered one, also getting the requisite config for tiers based on tier count.

Also, as an aside, configs are already mixed inside HStore (see 
CompoundConfiguration creation in ctor).
                
> port HBASE-6371 tier-based compaction from 0.89-fb to trunk - first slice 
> (not configurable by cf or dynamically)
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7055
>                 URL: https://issues.apache.org/jira/browse/HBASE-7055
>             Project: HBase
>          Issue Type: Task
>          Components: Compaction
>    Affects Versions: 0.96.0
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6371-squashed.patch, HBASE-6371-v2-squashed.patch, 
> HBASE-6371-v3-refactor-only-squashed.patch, 
> HBASE-6371-v4-refactor-only-squashed.patch, 
> HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7055-v0.patch, 
> HBASE-7055-v1.patch
>
>
> There's divergence in the code :(
> See HBASE-6371 for details.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to