[
https://issues.apache.org/jira/browse/HBASE-7232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506984#comment-13506984
]
stack commented on HBASE-7232:
------------------------------
bq. In HBaseObjectWritable is it cleaner to just increment the code (like on
line 258) rather than putting Object in the map ?
Yes. Thanks.
bq. Would having separate implementations of the HFile.FileInfo with different
reader methods be worth it ?
More pain than it is worth IMO.
bq. HFileWriterV2 is a white space only change is that intended ?
Let me remove from the next revision.
bq. Seems like most of the CompoundBloomFilter classes belong in io. Worth
moving them now ?
Not as part of this patch I'd say. They need a bit of work to undo Writables.
Might mess up backward compatibility moving their location. Would need to
check if class name is written to the hfile).
bq. Should CompoundBloomFilterWriter#cacheOnWrite() be renamed to
getCacheOnWrite ?
Yes.
Thanks for the review.
> Remove HbaseMapWritable
> -----------------------
>
> Key: HBASE-7232
> URL: https://issues.apache.org/jira/browse/HBASE-7232
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Attachments: 7232.txt, 7232.txt, 7232v2.txt
>
>
> Its used by hfile fileinfo only so need to convert fileinfo to remove this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
