[ 
https://issues.apache.org/jira/browse/HBASE-7250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509505#comment-13509505
 ] 

stack commented on HBASE-7250:
------------------------------

Something wrong in the class comment here?

{code}
"hbase.IntegrationTestRebalanceAndKillServers  s.runtime"
{code}

Should you say anything in class comment about which configs effect data size, 
how frequently the kills run, etc?  I see the class comment as what a user will 
peruse figuring if they want to run the test.  Should list the knobs to twiddle 
I'd say.

Should the numbers provided here be configurable?

+    runIngestTest(DEFAULT_RUN_TIME, 2500, 10, 100, 20);

Patch looks good to me.


                
> create integration test for balancing regions and killing region servers - 2
> ----------------------------------------------------------------------------
>
>                 Key: HBASE-7250
>                 URL: https://issues.apache.org/jira/browse/HBASE-7250
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>            Priority: Minor
>         Attachments: HBASE-7250-v0.patch, HBASE-7250-v1.patch
>
>
> The original test is too general; need another one that would be more 
> targeted and would test master logic in particular (e.g. not kill master). I 
> re-discovered HBASE-6060 using it on the first run :)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to