[
https://issues.apache.org/jira/browse/HBASE-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510706#comment-13510706
]
stack commented on HBASE-7213:
------------------------------
Do other logs have a '.log' suffix? You add .hlog with the below?
+ /** The META region's HLog filename extension */
+ public static final String META_HLOG_FILE_EXTN = ".meta.hlog";
The refactoring in MasterFileSystem to make a new getLogDirs method is nice.
The SSH changes look good. There is a hole though at the moment around -ROOT-
handling? We need to wait on -ROOT- removal before this can go in, right?
(The RootServerShutdownHandler would go....or should RSSH be calling MSSH when
it is done w/ its process?)
This below is given to an executor? Should have a better name than handler?
+ private UncaughtExceptionHandler handler;
Will we always create the metahlog just because getMetaHLog was called? Even
if we are NOT carrying .META.:
+ private HLog getMetaWAL() throws IOException {
+ if (this.hlogForMeta == null) {
If .META. moves away from a RS and then comes back, we'll just use the already
made meta log roller, etc.?
Replication will skip this .META. log?
It is intentional that MetaServices is still in the patch?
Changing param name from logName to logDir is good stuff
In SplitLogManager, we have added splitMetaLogDistributed. A more generic
method might have been splitLogDistributed that took a file path filter
instead...
There is a define for .META. HRegionInfo in HRegionInfo#FIRST_META_REGIONINFO
so you don't have to make it each time, FYI.
Don't have to deprecate the below I'd say. This is for 0.96 the singularity
and this is on a class with annotation @InterfaceAudience.Private
/** @return the HLog */
+ @Deprecated
public HLog getWAL();
+
+ /** @return the HLog for a particular region. Pass null for getting the
+ * default (common) WAL */
+ public HLog getWAL(HRegionInfo regionInfo) throws IOException;
Here....
- return new Path(dir, prefix + "." + filenum);
+ String child = prefix + "." + filenum;
+ if (forMeta) {
+ child += HConstants.META_HLOG_FILE_EXTN;
+ }
+ return new Path(dir, child);
the 'normal' WALs do not seem to pick up the suffix in here. Is it possible
that the '.log' is appended elsewhere? Are your .META. logs getting double
'.log'? Just wondering.
Good stuff
> Have HLog files for .META. edits only
> -------------------------------------
>
> Key: HBASE-7213
> URL: https://issues.apache.org/jira/browse/HBASE-7213
> Project: HBase
> Issue Type: Improvement
> Components: master, regionserver
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 7213-2.4.patch, 7213-in-progress.2.2.patch,
> 7213-in-progress.2.patch, 7213-in-progress.patch
>
>
> Over on HBASE-6774, there is a discussion on separating out the edits for
> .META. regions from the other regions' edits w.r.t where the edits are
> written. This jira is to track an implementation of that.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
