[
https://issues.apache.org/jira/browse/HBASE-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13511167#comment-13511167
]
Lars Hofhansl commented on HBASE-7282:
--------------------------------------
Rest of the patch looks good. What is this:
{code}
// Move the compaction into place.
- sf = completeCompaction(filesToCompact, writer);
- if (region.getCoprocessorHost() != null) {
- region.getCoprocessorHost().postCompact(this, sf);
+ if (this.conf.getBoolean("hbase.hstore.compaction.complete", true)) {
+ sf = completeCompaction(filesToCompact, writer);
+ if (region.getCoprocessorHost() != null) {
+ region.getCoprocessorHost().postCompact(this, sf);
+ }
+ } else {
+ // Create storefile around what we wrote with a reader on it.
+ sf = new StoreFile(this.fs, writer.getPath(), this.conf,
this.cacheConf,
+ this.family.getBloomFilterType(), this.dataBlockEncoder);
+ sf.createReader();
}
{code}
What is "hbase.hstore.compaction.complete"? And why would ever not want to have
this true? Was that wrongly pulled in from trunk?
> Backport Compaction Tool to 0.94
> --------------------------------
>
> Key: HBASE-7282
> URL: https://issues.apache.org/jira/browse/HBASE-7282
> Project: HBase
> Issue Type: Sub-task
> Components: Compaction
> Reporter: Matteo Bertozzi
> Assignee: Matteo Bertozzi
> Priority: Minor
> Fix For: 0.94.4
>
> Attachments: 7253.txt, 7253-v2.txt, HBASE-5616-0.94.patch,
> HBASE-5693-0.94.patch, HBASE-6327-0.94.patch, HBASE-7253-0.94.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
