[
https://issues.apache.org/jira/browse/HBASE-6469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13525985#comment-13525985
]
Nick Dimiduk commented on HBASE-6469:
-------------------------------------
bq. Updating patch on review board would make review easier.
Very well. The review has been re-opened and updated.
bq. Would introducing protobuf enum make the above check easier to maintain ?
I don't know. My protobuf exposure is minimal. Are you referring to replacing
the "boolean force" with an enumeration? What would you call that enumeration?
What other values would you advocate?
> Failure on enable/disable table will cause table state in zk to be left as
> enabling/disabling until master is restart
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-6469
> URL: https://issues.apache.org/jira/browse/HBASE-6469
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.2, 0.96.0
> Reporter: Enis Soztutar
> Assignee: Nick Dimiduk
> Fix For: 0.96.0, 0.94.4
>
> Attachments: 6469-expose-force.patch
>
>
> In Enable/DisableTableHandler code, if something goes wrong in handling, the
> table state in zk is left as ENABLING / DISABLING. After that we cannot force
> any more action from the API or CLI, and the only recovery path is restarting
> the master.
> {code}
> if (done) {
> // Flip the table to enabled.
> this.assignmentManager.getZKTable().setEnabledTable(
> this.tableNameStr);
> LOG.info("Table '" + this.tableNameStr
> + "' was successfully enabled. Status: done=" + done);
> } else {
> LOG.warn("Table '" + this.tableNameStr
> + "' wasn't successfully enabled. Status: done=" + done);
> }
> {code}
> Here, if done is false, the table state is not changed. There is also no way
> to set skipTableStateCheck from cli / api.
> We have run into this issue a couple of times before.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
