[ 
https://issues.apache.org/jira/browse/HBASE-5258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13526793#comment-13526793
 ] 

Ted Yu commented on HBASE-5258:
-------------------------------

For hbase.proto:
{code}
-  repeated Coprocessor coprocessors = 15;
+  /** Field ID 15 is reserved */
{code}
We should preserve ordinal in 0.94 But for trunk, I think we can bump up 
ordinal for completeSequenceId field

For TestClassLoading.java:
{code}
   private static final String[] regionServerSystemCoprocessors =
       new String[]{
-      regionCoprocessor1.getSimpleName(),
-      regionServerCoprocessor.getSimpleName()
-  };
-
-  private static final String[] regionServerSystemAndUserCoprocessors =
-      new String[] {
-      regionCoprocessor1.getSimpleName(),
-      regionCoprocessor2.getSimpleName(),
       regionServerCoprocessor.getSimpleName()
{code}
Originally regionCoprocessor1 was classified as system coprocessor. What was 
the reason for changing that ?

Thanks
                
> Move coprocessors set out of RegionLoad
> ---------------------------------------
>
>                 Key: HBASE-5258
>                 URL: https://issues.apache.org/jira/browse/HBASE-5258
>             Project: HBase
>          Issue Type: Task
>            Reporter: Ted Yu
>            Assignee: Sergey Shelukhin
>            Priority: Critical
>         Attachments: HBASE-5258-v0.patch
>
>
> When I worked on HBASE-5256, I revisited the code related to Ser/De of 
> coprocessors set in RegionLoad.
> I think the rationale for embedding coprocessors set is for maximum 
> flexibility where each region can load different coprocessors.
> This flexibility is causing extra cost in the region server to Master 
> communication and increasing the footprint of Master heap.
> Would HServerLoad be a better place for this set ?
> If required, region server should calculate disparity of loaded coprocessors 
> among regions and send report through HServerLoad

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to