[ 
https://issues.apache.org/jira/browse/HBASE-7205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13527140#comment-13527140
 ] 

Ted Yu edited comment on HBASE-7205 at 12/8/12 3:16 PM:
--------------------------------------------------------

Right, two cases here:
1. Classloader for jarX added to cache but CPH fails to load CP classname from 
this cl (ie no strong ref kept to cached cl)
  Valid in the current patch, the cl will be GCed by jvm eventually

2. Same jar packages multiple CP classes possible set on multiple tables:
First CP class loading will cache the jar classloader.
If then,one of the coproc config wrongly refer an invalid classname in this 
jar, the classlader shouldnt be evicted, he bravely loaded other cp classes and 
should stay in cache.

These cases are covered in v7 patch
                
      was (Author: amuraru):
    Right, two cases here:
1. Classloader for jarX added to cache but CPH fails to load CP classname from 
this cl (ie no strong ref kept to cached cl)
  Valid in the current patch, the cl will be GCed by jvm eventually

2. Same jar packages multiple CP classes possible set on multiple tables:
First CP class loading will cache the jar classloader.
If then,one of the coproc config wrongly refer an invalid classname in this 
jar, the classlader shouldnt be evicted, he bravely loaded other cp classes and 
should stay in cache.

These cases are covered in v7 patch

On 08.12.2012, at 07:41, "Ted Yu (JIRA)" 
<[email protected]<mailto:[email protected]>> wrote:

[https://issues.apache.org/jira/s/en_UK-chy13t-418945332/813/7/_/jira-logo-scaled.png]
[https://issues.apache.org/jira/secure/useravatar?avatarId=10452]
Ted 
Yu<https://issues.apache.org/jira/secure/ViewProfile.jspa?name=yuzhihong%40gmail.com>
 commented on [https://issues.apache.org/jira/images/icons/bug.gif]  
HBASE-7205<https://issues.apache.org/jira/browse/HBASE-7205>
Coprocessor classloader is replicated for all regions in the 
HRegionServer<https://issues.apache.org/jira/browse/HBASE-7205>




cache.remote not needed as it'll be GC'ed if not used anyway

Is it possible that the classloader referenced by cache eclipses another 
classloader which would load className class correctly ?





NeeThis message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

                  
> Coprocessor classloader is replicated for all regions in the HRegionServer
> --------------------------------------------------------------------------
>
>                 Key: HBASE-7205
>                 URL: https://issues.apache.org/jira/browse/HBASE-7205
>             Project: HBase
>          Issue Type: Bug
>          Components: Coprocessors
>    Affects Versions: 0.92.2, 0.94.2
>            Reporter: Adrian Muraru
>            Assignee: Ted Yu
>            Priority: Critical
>             Fix For: 0.96.0, 0.94.4
>
>         Attachments: 7205-v1.txt, 7205-v3.txt, 7205-v4.txt, 7205-v5.txt, 
> 7205-v6.txt, 7205-v7.txt, HBASE-7205_v2.patch
>
>
> HBASE-6308 introduced a new custom CoprocessorClassLoader to load the 
> coprocessor classes and a new instance of this CL is created for each single 
> HRegion opened. This leads to OOME-PermGen when the number of regions go 
> above hundres / region server. 
> Having the table coprocessor jailed in a separate classloader is good however 
> we should create only one for all regions of a table in each HRS.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to