[
https://issues.apache.org/jira/browse/HBASE-7262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528380#comment-13528380
]
stack commented on HBASE-7262:
------------------------------
Whats createContextName about? Should it be explained? Why would the param
serverName have HRegion in its name? Ditto HMaster.
Should BaseSource be fat w/ javadoc? You add new methods w/ nought:
+ String getMetricsContext();
+
+ String getMetricsDescription();
+
+ String getMetricsJmxContext();
+
+ String getMetricsName();
+1 on commit.
> Move HBaseRPC metrics to metrics2
> ---------------------------------
>
> Key: HBASE-7262
> URL: https://issues.apache.org/jira/browse/HBASE-7262
> Project: HBase
> Issue Type: Sub-task
> Components: metrics
> Affects Versions: 0.96.0
> Reporter: Elliott Clark
> Assignee: Elliott Clark
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: HBASE-7262-0.patch, HBASE-7262-1.patch,
> HBASE-7262-2.patch
>
>
> HBase RPC is the last thing still publishing through metrics1. We should
> move this into metrics2.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
