[ 
https://issues.apache.org/jira/browse/HBASE-7243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13528464#comment-13528464
 ] 

Nick Dimiduk commented on HBASE-7243:
-------------------------------------

bq. Why does the test need 2 region servers by default?

The test defined in this patch replicate the values defined by HBASE-7220. The 
timeout is arbitrary.

bq. Nit: not sure what the casing convention is, but fields like 
REGION_SERVER_COUNT appear to be constants when they aren't.

These fields are effectively constant in that they're resolved via 
configuration. I'm open to recommendations on formatting conventions.

bq. Some spacing issues.

Done.

bq. final?

Done.

bq. Not sure if it matters in Java... %s format for a long.

Java will call .toString() as appropriate. Switched to %d.

Will upload a new patch once [~nkeywal] has an opportunity to chime in.
                
> Test for creating a large number of regions
> -------------------------------------------
>
>                 Key: HBASE-7243
>                 URL: https://issues.apache.org/jira/browse/HBASE-7243
>             Project: HBase
>          Issue Type: Bug
>          Components: Region Assignment, regionserver, test
>            Reporter: Enis Soztutar
>            Assignee: Nick Dimiduk
>              Labels: noob
>             Fix For: 0.96.0
>
>         Attachments: 7243-integration-test-many-splits.diff
>
>
> After HBASE-7220, I think it will be good to write a unit test/IT to create a 
> large number of regions. We can put a reasonable timeout to the test. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to