Hi Julian, These simple methods will certainly get inlined by the JIT at the call sight. If you have any numbers which show improved performance, then it makes sense to manually inline it, but I would be really suprised if you do.
-Todd On Sun, Dec 9, 2012 at 11:19 PM, Julian Zhou <[email protected]> wrote: > Also for some other match.. methods in KeyValue. Could we make it flattened > for those method call? > > Best Regards, Julian > > > On Dec 09, 2012, at 10:37 PM, Julian Zhou <[email protected]> wrote: > > Maybe a little picky, from performance point of view, is it necessary of > "KeyValue.compareRows", since it directly call "Bytes.compareTo.." without > other logic. Since method invoking cost some byte codes, considering the > KeyValue.compareRows is called very frequently for StoreScanner, etc. Is it > necessary to replace it with raw "Bytes.compareTo.."? > > Best Regards, Julian -- Todd Lipcon Software Engineer, Cloudera
