[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529608#comment-13529608 ]
Shrijeet Paliwal commented on HBASE-5898: ----------------------------------------- Lars, I had put the stack trace here https://gist.github.com/4261746. It seems my issue is indeed a deadlock but its being triggered via a jvm bug http://bugs.sun.com/view_bug.do?bug_id=6822370 . We recently revisited our GC opts and removed UseMembar flag (did not seem useful). I guess any HBase install running java < 6u21 will potentially hit this deadlock. HBASE-3622 touched upon it. Thanks for your attention. > Consider double-checked locking for block cache lock > ---------------------------------------------------- > > Key: HBASE-5898 > URL: https://issues.apache.org/jira/browse/HBASE-5898 > Project: HBase > Issue Type: Improvement > Components: Performance > Affects Versions: 0.94.1 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Critical > Fix For: 0.94.3, 0.96.0 > > Attachments: 5898-0.94.txt, 5898-TestBlocksRead.txt, 5898-v2.txt, > 5898-v3.txt, 5898-v4.txt, 5898-v4.txt, HBASE-5898-0.patch, > HBASE-5898-1.patch, HBASE-5898-1.patch, hbase-5898.txt > > > Running a workload with a high query rate against a dataset that fits in > cache, I saw a lot of CPU being used in IdLock.getLockEntry, being called by > HFileReaderV2.readBlock. Even though it was all cache hits, it was wasting a > lot of CPU doing lock management here. I wrote a quick patch to switch to a > double-checked locking and it improved throughput substantially for this > workload. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira