[
https://issues.apache.org/jira/browse/HBASE-6788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532674#comment-13532674
]
Ted Yu commented on HBASE-6788:
-------------------------------
Nice test.
{code}
+ public static interface BlockingAuthenticationService
...
+ public static class TokenServer extends TokenProvider
{code}
BlockingAuthenticationService and TokenServer are only used in
TestTokenAuthentication. I think they can be private.
{code}
+ // Creation of a HSA will force a resolve.
+ InetSocketAddress initialIsa = new InetSocketAddress(hostname, port);
{code}
'HSA' -> InetSocketAddress or simply ISA.
{code}
+ // ignore passed in controller -- it's always null
+ ServerRpcController serverController = new ServerRpcController();
{code}
Does the above mean similar logic needs to be used in non-test code ?
> Convert AuthenticationProtocol to protocol buffer service
> ---------------------------------------------------------
>
> Key: HBASE-6788
> URL: https://issues.apache.org/jira/browse/HBASE-6788
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Blocker
> Fix For: 0.96.0
>
> Attachments: HBASE-6788_2.patch, HBASE-6788_3.patch,
> HBASE-6788_4.patch, HBASE-6788.patch
>
>
> With coprocessor endpoints now exposed as protobuf defined services, we
> should convert over all of our built-in endpoints to PB services.
> AccessControllerProtocol was converted as part of HBASE-5448, but the
> authentication token provider still needs to be changed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
