[
https://issues.apache.org/jira/browse/HBASE-3776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532759#comment-13532759
]
Ted Yu commented on HBASE-3776:
-------------------------------
Patch looks good.
TestHFileOutputFormat passes.
Some minor comments below.
{code}
+ private static Map<byte[], String> createFamilyConfValueMap(Configuration
conf, String confName) {
{code}
Please add javadoc for the above method.
{code}
+ StringBuilder bloomTypeConfigValue = new StringBuilder();
+ HTableDescriptor tableDescriptor = table.getTableDescriptor();
+ if (tableDescriptor == null) {
+ // could happen with mock table instance
+ return;
{code}
Please move StringBuilder ctor to after the above if block.
> Add Bloom Filter Support to HFileOutputFormat
> ---------------------------------------------
>
> Key: HBASE-3776
> URL: https://issues.apache.org/jira/browse/HBASE-3776
> Project: HBase
> Issue Type: Sub-task
> Reporter: Nicolas Spiegelberg
> Assignee: Anoop Sam John
> Priority: Critical
> Labels: hbase
> Fix For: 0.96.0
>
> Attachments: HBASE-3776.patch
>
>
> Add Bloom Filter support for bulk imports. Lacking a bloom filter, even on a
> single imported file, can cause perf degradation. Since we now set our
> compression type based on the HBase CF configuration, it would be good to
> follow this path for the bloom filter addition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
