[ 
https://issues.apache.org/jira/browse/HBASE-7315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532869#comment-13532869
 ] 

Gregory Chanan commented on HBASE-7315:
---------------------------------------

Thanks for the review.

bq. TestAccessController has a new import since you uploaded your patch.
Thanks, will fix in new version

bq. # HRegion#getLock doesn't appear to have any where that the first parameter 
is ever used.
bq. BatchOperationInProgress doesn't need to take in pairs anymore, as far as I 
can see

checkAndMutate needs it, because it holds the row lock over the entire (check, 
mutate) operation.  So the mutate part needs to take an existing rowlock.
                
> Remove support for client-side RowLocks
> ---------------------------------------
>
>                 Key: HBASE-7315
>                 URL: https://issues.apache.org/jira/browse/HBASE-7315
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Transactions/MVCC
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7315.patch, HBASE-7315-v2.patch, 
> HBASE-7315-v3.patch, HBASE-7315-v4.patch, HBASE-7315-v5.patch
>
>
> See comments in HBASE-7263.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to