[
https://issues.apache.org/jira/browse/HBASE-6945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535712#comment-13535712
]
Lars Hofhansl commented on HBASE-6945:
--------------------------------------
Some minor comments:
* Do we need to create the JVM object every time, or can be cache it statically
like we did with osStats?
* After the new JVM() the null check is unnecessary.
* in runUnixMXBeanMethod, do can we cache the outcome of classForName (even
when that is null), so that we do not have to make this call each time?
Maybe these are not problems, because this is not a hot code path?
> Compilation errors when using non-Sun JDKs to build HBase-0.94
> --------------------------------------------------------------
>
> Key: HBASE-6945
> URL: https://issues.apache.org/jira/browse/HBASE-6945
> Project: HBase
> Issue Type: Sub-task
> Components: build
> Affects Versions: 0.94.1
> Environment: RHEL 6.3, IBM Java 7
> Reporter: Kumar Ravi
> Assignee: Kumar Ravi
> Labels: patch
> Fix For: 0.96.0, 0.94.4
>
> Attachments: 6945-v2.txt, HBASE_0.94.3.patch, HBASE-6945.patch
>
>
> When using IBM Java 7 to build HBase-0.94.1, the following comilation error
> is seen.
> [INFO] -------------------------------------------------------------
> [ERROR] COMPILATION ERROR :
> [INFO] -------------------------------------------------------------
> [ERROR]
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[23,25]
> error: package com.sun.management does not exist
> [ERROR]
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[46,25]
> error: cannot find symbol
> [ERROR] symbol: class UnixOperatingSystemMXBean
> location: class ResourceAnalyzer
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[75,29]
> error: cannot find symbol
> [ERROR] symbol: class UnixOperatingSystemMXBean
> location: class ResourceAnalyzer
> /home/hadoop/hbase-0.94/src/test/java/org/apache/hadoop/hbase/ResourceChecker.java:[76,23]
> error: cannot find symbol
> [INFO] 4 errors
> [INFO] -------------------------------------------------------------
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD FAILURE
> [INFO]
> ------------------------------------------------------------------------
> I have a patch available which should work for all JDKs including Sun.
> I am in the process of testing this patch. Preliminary tests indicate the
> build is working fine with this patch. I will post this patch when I am done
> testing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
