[
https://issues.apache.org/jira/browse/HBASE-7321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536753#comment-13536753
]
Ted Yu commented on HBASE-7321:
-------------------------------
{code}
+ * (In the future other cancelable HReigon methods could eventulaly add a
{code}
typo: eventulaly
{code}
+ public void addRegionToSnapshot(SnapshotDescription desc,
+ ForeignExceptionCheckable failureMonitor) throws IOException {
{code}
Add javadoc for the parameters.
{code}
+ if (LOG.isDebugEnabled()) LOG.debug("Adding snapshot references for " +
storeFiles
+ + " hfiles");
{code}
Use curly braces for the above if statement. Here storeFiles.toString() is
called, would that reveal useful information ?
{code}
+ // 2.3. create "reference" to this store file
{code}
I don't see 2.1 or 2.2 :-)
{code}
+ * framework. Its enter stage forces does nothing. Its leave stage then
builds the region
{code}
Can 'forces' be omitted ?
{code}
+public class FlushSnapshotSubprocedure extends Subprocedure {
{code}
Add annotation for audience and stability.
Looking at SnapshotSubprocedurePool.java:
{code}
long keepAlive = conf.getLong(
RegionServerSnapshotManager.SNAPSHOT_TIMEOUT_MILLIS_KEY,
...
executor = new ThreadPoolExecutor(1, threads, keepAlive, TimeUnit.SECONDS,
{code}
keepAlive is in milliseconds, right ? There seems to be inconsistency in units.
{code}
+ class RegionSnapshotTask implements Callable<Void> {
{code}
The above class can be private, right ?
{code}
+ case LOGROLL:
+ throw new IllegalArgumentException("Unimplememted snapshot type:" +
snapshot.getType());
{code}
How about throwing UnsupportedOperationException ?
{code}
+ * Test create/using/deleting snapshots from the client
{code}
create -> creating
{code}
+ * TODO This is essentially a clone of TestSnapshotFromClient. This is worth
refactoring this
...
+ * TODO This is essentially a clone of TestRestoreSnapshotFromClient. This is
worth refactoring
{code}
Are you going to create a separate JIRA for the above actions ?
> Simple Flush Snapshot
> ---------------------
>
> Key: HBASE-7321
> URL: https://issues.apache.org/jira/browse/HBASE-7321
> Project: HBase
> Issue Type: Sub-task
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Attachments: hbase-7321.v2.patch, pre-hbase-7321.v2.patch
>
>
> This snapshot style just issues a region flush and then "snapshots" the
> region.
> This is a simple implementation that gives the equivalent of copytable
> consistency. While by most definitions of consistency if a client writes A
> and then write B to different region servers, only neither, only A, or both
> A+B writes should be present, this one allows the only B case.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
