[ 
https://issues.apache.org/jira/browse/HBASE-7218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13537312#comment-13537312
 ] 

Jesse Yates commented on HBASE-7218:
------------------------------------

{quote}
1) Junk on failure. This is unaccepatble IMO. If rename crashes we should not 
leave any corrupted snapshots behind. I'm concerned about the original ss if 
(not sure about this) if the recursive hdfs delete is not atomic.
{quote}

With the cleanup of the /hbase/.snapshot/.tmp directory (HBASE-7240) we remove 
any of the junk from a previous failure.

As the directory rename is atomic WRT the namenode, we then have atomic rename 
with 'rollback in case of failure' semantics (unless I'm missing something).
                
> Rename Snapshot
> ---------------
>
>                 Key: HBASE-7218
>                 URL: https://issues.apache.org/jira/browse/HBASE-7218
>             Project: HBase
>          Issue Type: Sub-task
>          Components: snapshots
>    Affects Versions: hbase-6055
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>             Fix For: hbase-6055
>
>         Attachments: HBASE-7218-v0.patch, HBASE-7218-v1.patch
>
>
> Add the ability to rename a snapshot.
> HBaseAdmin.renameSnapshot(oldName, newName)
> shell: snapshot_rename 'oldName', 'newName'

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to