[
https://issues.apache.org/jira/browse/HBASE-7405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Devaraj Das updated HBASE-7405:
-------------------------------
Attachment: 7405-3.patch
7405-3.patch
This patch mainly adds some javadoc around the new params added to the
ColumnInterpreter class.
This patch doesn't change the signature of the methods in the AggregateClient
(Stack's last comment). The reason being that the ColumnInterpreter is typed
with those types, and the ColumnInterpreter is passed as argument to the
AggregateClient methods.
I thought that I could fix this by moving the generics declaration to the
AggregateClient class declaration. That works but unfortunately requires all
the callers to do explicit typecasts for the expected return types of the
AggregateClient methods (somewhat odd but yeah..), making the whole thing look
ugly.
On the plus side:
Users are mostly going to only provide custom implementations for the
ColumnInterpreter class, and, this sort of a long'ish generics signature is not
required for the ColumnInterpreter methods.
> Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter
> user code bits
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-7405
> URL: https://issues.apache.org/jira/browse/HBASE-7405
> Project: HBase
> Issue Type: Sub-task
> Components: Coprocessors, Protobufs
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 7405-1.patch, 7405-2.patch, 7405-3.patch, 7405-3.patch
>
>
> Enforce PB ser/de for Aggregate protocol and associated ColumnInterpreter
> user code bits
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
