[
https://issues.apache.org/jira/browse/HBASE-7212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539447#comment-13539447
]
Ted Yu edited comment on HBASE-7212 at 12/26/12 1:10 AM:
---------------------------------------------------------
I encountered some error submitting review comments on review board.
The following two new methods can be declared package private:
{code}
public static void waitForLatch(CountDownLatch latch, ForeignExceptionSnare
monitor,
{code}
{code}
public Procedure createProcedure(ForeignExceptionDispatcher fed, String
procName, byte[] procArgs,
{code}
Can we use MapMaker from Guava so that we don't need to introduce
WeakValueMapping class ?
See CorpocessorHost.java for an example.
was (Author: [email protected]):
I encountered some error submitting review comments.
The following two new methods can be declared package private:
{code}
public static void waitForLatch(CountDownLatch latch, ForeignExceptionSnare
monitor,
{code}
{code}
public Procedure createProcedure(ForeignExceptionDispatcher fed, String
procName, byte[] procArgs,
{code}
> Globally Barriered Procedure mechanism
> --------------------------------------
>
> Key: HBASE-7212
> URL: https://issues.apache.org/jira/browse/HBASE-7212
> Project: HBase
> Issue Type: Sub-task
> Components: snapshots
> Affects Versions: hbase-6055
> Reporter: Jonathan Hsieh
> Assignee: Jonathan Hsieh
> Fix For: hbase-6055
>
> Attachments: 121127-global-barrier-proc.pdf, hbase-7212.patch,
> hbase-7212.v5.patch, pre-hbase-7212.patch, pre-hbase-7212.v5.patch
>
>
> This is a simplified version of what was proposed in HBASE-6573. Instead of
> claiming to be a 2pc or 3pc implementation (which implies logging at each
> actor, and recovery operations) this is just provides a best effort global
> barrier mechanism called a Procedure.
> Users need only to implement a methods to acquireBarrier, to act when
> insideBarrier, and to releaseBarrier that use the ExternalException
> cooperative error checking mechanism.
> Globally consistent snapshots require the ability to quiesce writes to a set
> of region servers before a the snapshot operation is executed. Also if any
> node fails, it needs to be able to notify them so that they abort.
> The first cut of other online snapshots don't need the fully barrier but may
> still use this for its error propagation mechanisms.
> This version removes the extra layer incurred in the previous implementation
> due to the use of generics, separates the coordinator and members, and
> reduces the amount of inheritance used in favor of composition.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
