[
https://issues.apache.org/jira/browse/HBASE-7055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539640#comment-13539640
]
stack commented on HBASE-7055:
------------------------------
[~sershe] The community rules here --
http://hbase.apache.org/book.html#decisions -- say two +1s... they don't say
two +1s and whatever stack says (smile). I was going to suggest that you get
at least a +1 from one of the compaction component owners but it seems like no
one has volunteered for this role (I suppose we made the role as we went
through this issue).
Yeah, in general, I'm trying to work on 0.96 issues. I think it kinda critical
that the project have a 0.96. soon. It has been too long since our last major
version.
My high level concern with this issue, still, is that it is a complex feature
-- not only in operation but in configuration and in interpretation of its
workings -- and complexity is an attribute we could do with less of not more.
The justification for including this feature seems weak as currently written
(The release note currently starts "A tier based compaction algorithm has been
developed...." as though the fact that the feature was written is enough to
justify its inclusion or the design document starts "The goal of
the compaction selection algorithm is to
schedule compactions efficiently." but there are no 'fit criteria'
included in the document to prove the mechanism is working 'efficiently').
Let me review the patch up on rb.
> port HBASE-6371 tier-based compaction from 0.89-fb to trunk - first slice
> (not configurable by cf or dynamically)
> -----------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7055
> URL: https://issues.apache.org/jira/browse/HBASE-7055
> Project: HBase
> Issue Type: Task
> Components: Compaction
> Affects Versions: 0.96.0
> Reporter: Sergey Shelukhin
> Assignee: Sergey Shelukhin
> Fix For: 0.96.0
>
> Attachments: HBASE-6371-squashed.patch, HBASE-6371-v2-squashed.patch,
> HBASE-6371-v3-refactor-only-squashed.patch,
> HBASE-6371-v4-refactor-only-squashed.patch,
> HBASE-6371-v5-refactor-only-squashed.patch, HBASE-7055-v0.patch,
> HBASE-7055-v1.patch, HBASE-7055-v2.patch, HBASE-7055-v3.patch,
> HBASE-7055-v4.patch
>
>
> There's divergence in the code :(
> See HBASE-6371 for details.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
