[
https://issues.apache.org/jira/browse/HBASE-5598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540027#comment-13540027
]
stack commented on HBASE-5598:
------------------------------
@nkeywal Do you want to do part2 in another issue linked to from here since we
have already committed a patch against this issue?
Why move the defines in HRegionInfo?
This is a nice trick:
{code}
+ @edu.umd.cs.findbugs.annotations.SuppressWarnings
(value="ES_COMPARING_STRINGS_WITH_EQ",
+ justification="Optimization")
{code}
What warning do we suppress by doing this:
- return new StringBuilder("AuthResult")
- .append(toContextString()).toString();
+ return "AuthResult" + toContextString();
I know its not 'important' but these kinda findings are good:
- StringBuffer sb = new StringBuffer("");
+ StringBuilder sb = new StringBuilder("");
We are going back to findbugs 2.0.1 from 2.5.2?
Is this define used anywhere: findbugs-maven-plugin.version
Good work Nicolas
> Analyse and fix the findbugs reporting by QA and add invalid bugs into
> findbugs-excludeFilter file
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-5598
> URL: https://issues.apache.org/jira/browse/HBASE-5598
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: Uma Maheswara Rao G
> Assignee: Uma Maheswara Rao G
> Priority: Critical
> Fix For: 0.96.0
>
> Attachments: 5598.part1.patch, 5598.part2.patch, 5598.part2.patch,
> ASF.LICENSE.NOT.GRANTED--findbugs-gui-report.jpg, HBASE-5598.patch
>
>
> There are many findbugs errors reporting by HbaseQA. HBASE-5597 is going to
> up the OK count.
> This may lead to other issues when we re-factor the code, if we induce new
> valid ones and remove invalid bugs also can not be reported by QA.
> So, I would propose to add the exclude filter file for findbugs(for the
> invalid bugs). If we find any valid ones, we can fix under this JIRA.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
