[ 
https://issues.apache.org/jira/browse/HBASE-7450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540464#comment-13540464
 ] 

Ted Yu commented on HBASE-7450:
-------------------------------

Please generate patch for trunk.
TestIPC.java needs license header. Trunk version should also include test 
category - small test should do.
Indentation should be two spaces per tab. You can import 
dev-support/hbase_eclipse_formatter.xml into Eclipse.
{code}
-        throw e;
{code}
e isn't re-thrown for IOException, why ?
                
> orphan RPC connection in HBaseClient leaves "null" out member, causing NPE in 
> HCM
> ---------------------------------------------------------------------------------
>
>                 Key: HBASE-7450
>                 URL: https://issues.apache.org/jira/browse/HBASE-7450
>             Project: HBase
>          Issue Type: Bug
>          Components: IPC/RPC
>    Affects Versions: 0.92.0
>            Reporter: Zavier Gao
>             Fix For: 0.96.0
>
>         Attachments: 7450_v1.txt
>
>
> Just like: https://issues.apache.org/jira/browse/HADOOP-7428
> Exceptions except IOException thrown in setupIOstreams would leave the 
> connection half-setup. But the connection would not close utill it become 
> timeout. The orphane connection cause NPE when is used in HCM.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to