[
https://issues.apache.org/jira/browse/HBASE-7428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540525#comment-13540525
]
Hadoop QA commented on HBASE-7428:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12562394/7428-consolidate-ZK_SESSION_TIMEOUT.0.diff
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 2
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestMasterReplication
org.apache.hadoop.hbase.coprocessor.TestClassLoading
org.apache.hadoop.hbase.replication.TestMultiSlaveReplication
{color:red}-1 core zombie tests{color}. There are 4 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/3735//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/3735//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/3735//console
This message is automatically generated.
> There are multiple HConstants for configuring Zookeeper timeout
> ---------------------------------------------------------------
>
> Key: HBASE-7428
> URL: https://issues.apache.org/jira/browse/HBASE-7428
> Project: HBase
> Issue Type: Improvement
> Reporter: Nick Dimiduk
> Assignee: Nick Dimiduk
> Priority: Minor
> Labels: noob
> Fix For: 0.96.0
>
> Attachments: 7428-consolidate-ZK_SESSION_TIMEOUT.0.diff
>
>
> From [~te...@apache.org] to dev@:
> {quote}
> There are two constants with the same value:
> HConstants.ZOOKEEPER_SESSION_TIMEOUT and HConstants.ZK_SESSION_TIMEOUT
> HConstants.ZOOKEEPER_SESSION_TIMEOUT is only used in tests.
> HConstants.ZK_SESSION_TIMEOUT is used by ZKUtil
> Shall we remove HConstants.ZOOKEEPER_SESSION_TIMEOUT and let tests use
> HConstants.ZK_SESSION_TIMEOUT ?
> {quote}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
