[
https://issues.apache.org/jira/browse/HBASE-6039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540649#comment-13540649
]
stack commented on HBASE-6039:
------------------------------
[~gchanan] Was wondering why you implemented BlockingInterface in the below G:
{code}
+public interface MasterProtocol extends VersionedProtocol,
MasterService.BlockingInterface {
+
+ /**
+ * @param c Unused (set to null).
+ * @param req IsMasterRunningRequest
+ * @return IsMasterRunningRequest that contains:<br>
+ * isMasterRunning: true if master is available
+ * @throws ServiceException
+ */
+ public IsMasterRunningResponse isMasterRunning(RpcController c,
IsMasterRunningRequest req)
+ throws ServiceException;
+}
{code}
Also, why if we are implementing BlockingInterface, would you include here the
isMasterRunning method since it is back in BlockingInterface anyways, right?
I'm trying to figure out if any particular reason for the protocol definitions
we have. Above we have mention of RpcController but everywhere it comes up we
just null it out. Was it just there transitionally or did you find you needed
it? (Sorry to be asking this long after commit). Thanks.
> Remove HMasterInterface and replace with something similar to
> RegionServerStatusProtocol
> ----------------------------------------------------------------------------------------
>
> Key: HBASE-6039
> URL: https://issues.apache.org/jira/browse/HBASE-6039
> Project: HBase
> Issue Type: Task
> Components: IPC/RPC, master
> Reporter: Gregory Chanan
> Assignee: Gregory Chanan
> Fix For: 0.96.0
>
> Attachments: HBASE-6039.patch, HBASE-6039-v2.patch
>
>
> Me: Once everything in HMasterInterface is converted to use PB, we can either
> declare a new class for the representation (similar to
> RegionServerStatusProtocol) or just re-purpose HMasterInterface for that.
> What is your preference?
> Stack: Lets do what Jimmy did, make a new class and kill the old.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
