[ 
https://issues.apache.org/jira/browse/HBASE-5620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13540670#comment-13540670
 ] 

stack commented on HBASE-5620:
------------------------------

[~jxiang] BlockingInterface has references to RpcController in it, a facility 
we make no use of. For example, here is the get from the Interface:

{code}
      public 
org.apache.hadoop.hbase.protobuf.generated.ClientProtos.GetResponse get(
          com.google.protobuf.RpcController controller,
          org.apache.hadoop.hbase.protobuf.generated.ClientProtos.GetRequest 
request)
          throws com.google.protobuf.ServiceException;
{code}

Whenever we use the method, we always pass null for the RpcController as in:

{code}
      GetResponse response = client.get(null, request);
{code}

Were you thinking this was ok price to pay for not redefining the Interface 
minus mention of RpcProtocol?  Thanks.
                
> Convert the client protocol of HRegionInterface to PB
> -----------------------------------------------------
>
>                 Key: HBASE-5620
>                 URL: https://issues.apache.org/jira/browse/HBASE-5620
>             Project: HBase
>          Issue Type: Sub-task
>          Components: IPC/RPC, master, migration, regionserver
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>             Fix For: 0.96.0
>
>         Attachments: hbase-5620-sec.patch, hbase-5620_v3.patch, 
> hbase-5620_v4.patch, hbase-5620_v4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to