[ 
https://issues.apache.org/jira/browse/HBASE-7467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13541220#comment-13541220
 ] 

Jesse Yates commented on HBASE-7467:
------------------------------------

Oh, yeah, that makes sense. This could still throw an exception though if we 
get a file added under that directory (see HBASE-7465). Make it something like:
{code}
   try {
      return fs.delete(toCheck, false);
    } catch (IOException e) {
      if (LOG.isTraceEnabled()) {
        LOG.trace("Couldn't delete directory: " + toCheck+ e);
      }
      return false;
    }
{code}

for the delete and I'm +1
                
> CleanerChore checkAndDeleteDirectory not deleting empty directories.
> --------------------------------------------------------------------
>
>                 Key: HBASE-7467
>                 URL: https://issues.apache.org/jira/browse/HBASE-7467
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Marc Spaggiari
>            Priority: Minor
>             Fix For: 0.96.0, 0.94.5
>
>         Attachments: HBASE-7467.patch
>
>
> CleanerChore checkAndDeleteDirectory is not deleting empty directories. As a 
> result, some directories are kept in the FS but should have been removed.
> To reproduce, simply create an empty directory under 
> /hbase/.archive/table_name/. If you place a file into this directory, it's 
> not more empty and therefore it's correctly removed.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to