[
https://issues.apache.org/jira/browse/HBASE-7488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13543439#comment-13543439
]
Ted Yu commented on HBASE-7488:
-------------------------------
{code}
+ e.printStackTrace();
+ LOG.error("Error while retrieving the start key from region " +
Bytes.toStringBinary(regionName), e);
{code}
You can omit the printStackTrace() call - the error log would reveal
information.
The error log exceeds 100 characters.
{code}
+ return locateRegion(HRegionInfo.getTableName(regionName),
HRegionInfo.getStartKey(regionName), false, true);
{code}
Wrap long line above.
{code}
+ */
+ public List<HRegionLocation> locateRegions(byte[] tableName)
{code}
Add @Override for the above method.
There is no need to repeat javadoc when @Override is present.
Please also note that locateRegions() are expensive methods.
> Implement HConnectionManager.locateRegions which is currently returning null.
> -----------------------------------------------------------------------------
>
> Key: HBASE-7488
> URL: https://issues.apache.org/jira/browse/HBASE-7488
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Marc Spaggiari
> Assignee: Jean-Marc Spaggiari
> Priority: Critical
> Labels: HConnectionManager
> Attachments: HBASE-7488-v0-0.94.patch, HBASE-7488-v0-trunk.patch,
> HBASE-7488-v1-trunk.patch, HBASE-7488-v2-trunk.patch,
> HBASE-7488-v3-trunk.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
