[
https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13544045#comment-13544045
]
Ted Yu commented on HBASE-6669:
-------------------------------
{code}
+ public void testMaxWithValidRange() throws Throwable {
{code}
Do you specify range in the above method ? Range is specified in
testMaxWithValidRange2
{code}
+ public void testMaxWithValidRangeWithNoCQ() throws Throwable {
{code}
Rename the method testMaxWithValidRangeWithoutCQ
{code}
+ log.debug("Inside readFields method of DoubleColumnInterpreter");^M
{code}
Please remove unnecessary debug logs.
{code}
+ public BigDecimal getValue(byte[] paramArrayOfByte1, byte[]
paramArrayOfByte2, KeyValue kv)^M
{code}
The first two parameters are family and qualifier. Please name them accordingly.
{code}
+ if ((((val1 == null) ? 1 : 0) ^ ((val2 == null) ? 1 : 0)) != 0) return
((val1 == null) ? val2^M
+ : val1);^M
{code}
Since the if statement spans two lines, use curly braces to surround the return
statement.
I don't know where the ^M came from. It would be nice to remove them (using
tool such as dos2unix).
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> ------------------------------------------------------------------------------
>
> Key: HBASE-6669
> URL: https://issues.apache.org/jira/browse/HBASE-6669
> Project: HBase
> Issue Type: New Feature
> Components: Client, Coprocessors
> Affects Versions: 0.94.3
> Reporter: Anil Gupta
> Priority: Minor
> Labels: client, coprocessors
> Fix For: 0.94.5
>
> Attachments: 6669-0.94-v4.txt, BigDecimalColumnInterpreter.java,
> BigDecimalColumnInterpreter.patch, BigDecimalColumnInterpreter.patch,
> HBASE-6669.patch, HBASE-6669-v2.patch, HBASE-6669-v3.patch,
> TestBDAggregateProtocol.patch, TestBigDecimalColumnInterpreter.java
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values
> stored as BigDecimal in HBase. I would like to commit the
> BigDecimalColumnInterpreter into HBase. In my opinion this class can be used
> by a wide variety of users. Please let me know if its not appropriate to add
> this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
