[ 
https://issues.apache.org/jira/browse/HBASE-7474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13547471#comment-13547471
 ] 

Ted Yu commented on HBASE-7474:
-------------------------------

For SortingProtocol:
{code}
+  <T> Result[] sortIncreasing(Scan scan, byte[] columnFamily, byte[] 
columnQualifier,
{code}
I think sortAscending would be more familiar to people who have worked with 
RDBMS.
{code}
+  <T> Result[] sortDecreasing(Scan scan, byte[] columnFamily, byte[] 
columnQualifier,
{code}
sortDescending would be a better method name.
{code}
+   * @param singleRegion does this scan request spans multiple regions?
{code}
spelling: 'spans' -> 'span'

Looking at SortingProtocolImplementation.sortIncreasing(), singleRegion is not 
referenced in the loop - we scan until there is no more row. Some clarification 
is needed in javadoc and variable name.
                
> Endpoint Implementation to support Scans with Sorting of Rows based on column 
> values(similar to "order by" clause of RDBMS)
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-7474
>                 URL: https://issues.apache.org/jira/browse/HBASE-7474
>             Project: HBase
>          Issue Type: New Feature
>          Components: Coprocessors, Scanners
>    Affects Versions: 0.94.3
>            Reporter: Anil Gupta
>            Priority: Minor
>              Labels: coprocessors, scan, sort
>             Fix For: 0.94.5
>
>         Attachments: hbase-7474.patch, hbase-7474-v2.patch, 
> SortingEndpoint_high_level_flowchart.pdf
>
>
> Recently, i have developed an Endpoint which can sort the Results(rows) on 
> the basis of column values. This functionality is similar to "order by" 
> clause of RDBMS. I will be submitting this Patch for HBase0.94.3
> I am almost done with the initial development and testing of feature. But, i 
> need to write the JUnits for this. I will also try to make design doc.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, inc

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to