[ 
https://issues.apache.org/jira/browse/HBASE-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550564#comment-13550564
 ] 

Ted Yu commented on HBASE-7535:
-------------------------------

Some logs were removed in patch:
{code}
-    LOG.info("getReferredToFile(): p=" + p + " g1=" + m.group(1) + " g2=" + 
m.group(2));
+
{code}
Would they be useful in debugging ? Maybe change to debug level.
{code}
+      LOG.info("restore file as link-link=" + hfileName + " in=" + familyDir);
{code}
'link-link' means HFileLink created from HFileLink. Maybe call it 
'link-from-link' or something similar ?

In the test:
{code}
+    HTableDescriptor htd = createTableDescriptor("table");
{code}
Please create a constant for table name so that it can be referred later:
{code}
+    Path basePath = new Path(new Path("table", "region"), "cf");
{code}

                
> Fix restore reference files
> ---------------------------
>
>                 Key: HBASE-7535
>                 URL: https://issues.apache.org/jira/browse/HBASE-7535
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Blocker
>         Attachments: HBASE-7535-v0.patch
>
>
> After HBASE-7419 the HFileLink regex became stricter, to have the proper 
> isHFileLink() check.
> but HFileLink should open both reference and hfiles
> since the main idea behind it is open stuff in /table/region/family/XYZ
> This patch fix the reference (split files) restore problem and open the 
> hfilelink regex for HFileLink(/table/region/family/xyz).open()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to