[
https://issues.apache.org/jira/browse/HBASE-7471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13550605#comment-13550605
]
Ted Yu commented on HBASE-7471:
-------------------------------
Snapshot is enabled / disabled programmatically in the snapshot tests:
{code}
find hbase-server/src/test -name '*.java' -exec grep HBASE_SNAPSHOT_ENABLED {}
\; -print
TEST_UTIL.getConfiguration().setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED,
true);
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestRestoreSnapshotFromClient.java
conf.setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED, true);
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java
conf.setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED, true);
hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestSnapshotFromMaster.java
conf.setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED, true);
conf.setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED, false);
conf.setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED, false);
conf.setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED, false);
hbase-server/src/test/java/org/apache/hadoop/hbase/master/snapshot/TestSnapshotManager.java
TEST_UTIL.getConfiguration().setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED,
true);
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestExportSnapshot.java
conf.setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED, true);
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.java
TEST_UTIL.getConfiguration().setBoolean(SnapshotManager.HBASE_SNAPSHOT_ENABLED,
true);
hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreFlushSnapshotFromClient.java
{code}
I ran the following tests and didn't see regression:
{code}
Running org.apache.hadoop.hbase.client.TestRestoreSnapshotFromClient
2013-01-10 16:20:38.147 java[90010:1203] Unable to load realm info from
SCDynamicStore
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 163.057 sec
Running org.apache.hadoop.hbase.client.TestSnapshotFromAdmin
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.484 sec
Running org.apache.hadoop.hbase.client.TestSnapshotFromClient
2013-01-10 16:23:26.544 java[90034:1203] Unable to load realm info from
SCDynamicStore
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 46.243 sec
Running org.apache.hadoop.hbase.master.cleaner.TestSnapshotFromMaster
2013-01-10 16:24:13.399 java[90049:1203] Unable to load realm info from
SCDynamicStore
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.411 sec
Running org.apache.hadoop.hbase.master.snapshot.TestSnapshotFileCache
2013-01-10 16:25:01.452 java[90069:1203] Unable to load realm info from
SCDynamicStore
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.187 sec
Running org.apache.hadoop.hbase.master.snapshot.TestSnapshotHFileCleaner
2013-01-10 16:25:55.344 java[90079:1203] Unable to load realm info from
SCDynamicStore
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.588 sec
Running org.apache.hadoop.hbase.master.snapshot.TestSnapshotLogCleaner
2013-01-10 16:25:56.189 java[90081:1203] Unable to load realm info from
SCDynamicStore
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.555 sec
Running org.apache.hadoop.hbase.master.snapshot.TestSnapshotManager
2013-01-10 16:25:57.092 java[90083:1203] Unable to load realm info from
SCDynamicStore
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.827 sec
Running org.apache.hadoop.hbase.snapshot.TestExportSnapshot
2013-01-10 16:25:58.091 java[90085:1203] Unable to load realm info from
SCDynamicStore
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 32.206 sec
Running org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
2013-01-10 16:26:30.911 java[90109:1203] Unable to load realm info from
SCDynamicStore
Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.788 sec
Running org.apache.hadoop.hbase.snapshot.TestLogrollSnapshotFromClient
2013-01-10 16:27:19.320 java[90130:1203] Unable to load realm info from
SCDynamicStore
Tests run: 4, Failures: 0, Errors: 0, Skipped: 4, Time elapsed: 25.553 sec
Running org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient
2013-01-10 16:27:45.492 java[90145:1203] Unable to load realm info from
SCDynamicStore
Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 99.052 sec
Running org.apache.hadoop.hbase.snapshot.TestRestoreLogrollSnapshotFromClient
2013-01-10 16:29:25.169 java[90171:1203] Unable to load realm info from
SCDynamicStore
Tests run: 5, Failures: 0, Errors: 0, Skipped: 5, Time elapsed: 24.156 sec
Running org.apache.hadoop.hbase.snapshot.TestSnapshotDescriptionUtils
2013-01-10 16:29:49.886 java[90181:1203] Unable to load realm info from
SCDynamicStore
Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.686 sec <<<
FAILURE!
Running org.apache.hadoop.hbase.snapshot.TestSnapshotLogSplitter
2013-01-10 16:29:50.891 java[90183:1203] Unable to load realm info from
SCDynamicStore
Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.043 sec
Running org.apache.hadoop.hbase.snapshot.TestSnapshotTask
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.41 sec
{code}
Can you be a little more specific ?
Thanks
> Enable Cleaners required for Snapshots by default
> -------------------------------------------------
>
> Key: HBASE-7471
> URL: https://issues.apache.org/jira/browse/HBASE-7471
> Project: HBase
> Issue Type: Sub-task
> Components: Client, master, regionserver, snapshots, Zookeeper
> Reporter: Jonathan Hsieh
> Assignee: Ted Yu
> Fix For: hbase-6055, 0.96.0
>
> Attachments: 7471.txt
>
>
> Currently, snapshots require admins to add configuration to their
> hbase-site.xml to have snapshot functionality available. It is at the moment
> off by default.
> {code}
> <property>
> <name>hbase.snapshot.enabled</name>
> <value>true</value>
> </property>
> {code}
> Maybe we should just enable snapshots by default. Discuss.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
