[
https://issues.apache.org/jira/browse/HBASE-7434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
stack updated HBASE-7434:
-------------------------
Resolution: Invalid
Status: Resolved (was: Patch Available)
This is a good patch. Thank you for making it Hiroshi. It is no longer
applicable though now that versionedprotocol has been removed. Sorry for your
working on something that we could not use. Please keep up your quality
submissions... lets get the rest of your contribs in.
> Use generics appropriately in RPCEngine and reduce casts, with fixing a
> related bug of breaking thread-safety in HConnectionManager
> -----------------------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-7434
> URL: https://issues.apache.org/jira/browse/HBASE-7434
> Project: HBase
> Issue Type: Improvement
> Reporter: Hiroshi Ikeda
> Assignee: Hiroshi Ikeda
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7434.patch, HBASE-7434-V2.patch
>
>
> In RpcEngine,
> {code}
> VersionedProtocol getProxy(Class<? extends VersionedProtocol> protocol, ...)
> {code}
> should be
> {code}
> <T extends VersionedProtocol> T getProxy(Class<T> protocol, ...)
> {code}
> Also, while removing casts I encountered a bug of the method
> HConnectionManager.HConnectionImplementation.getProtocol() using broken logic
> just like double-checked locking for HashMap.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
