[
https://issues.apache.org/jira/browse/HBASE-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jean-Daniel Cryans updated HBASE-7545:
--------------------------------------
Attachment: HBASE-7545.patch
Attaching the changes I described in this jira's description.
Other changes I made:
- Somehow the number of RS went to 3 in TestReplication, brought it back to 2.
- Brought the timeouts back to what they were, I don't think they help much
anyway. Can revisit.
- When I extracted TestReplicationSmallTests it was always failing, I found
out that the HTable for the master cluster was left with auto flush turned off
from another method. I now htable1.setAutoFlush(true) in setUp().
- I figured cases where the stats thread was dying because it was trying to
get the current position from a null reader, I added some safeguards against
this.
> [replication] Break out TestReplication into manageable classes
> ---------------------------------------------------------------
>
> Key: HBASE-7545
> URL: https://issues.apache.org/jira/browse/HBASE-7545
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Daniel Cryans
> Assignee: Jean-Daniel Cryans
> Fix For: 0.96.0
>
> Attachments: HBASE-7545.patch
>
>
> This has been discussed before but after trying to debug the last failure on
> Jenkins where I saw the time go back and forth (if you don't care about your
> own sanity do checkout
> https://builds.apache.org/job/HBase-TRUNK/3726/testReport/junit/org.apache.hadoop.hbase.replication/TestReplicationWithCompression/testDeleteTypes/)
> I think it is time to break out TestReplication.
> The difficulty is that the setup for the 2 clusters is a lot of code I don't
> want to duplicate. I'm thinking that we can keep {{setUpBeforeClass}} there
> and have the other classes extend TestReplication (which should also change
> name). I'm thinking of the following new classes:
> - TestReplicationSmallTests, contains the easy methods that don't mess
> around too much.
> - TestReplicationQueueFailover, contains one test of the same name
> - TestReplicationDisableInactivePeer, contains one test of the same name
> - Rename TestReplicationWithCompression
> TestReplicationQueueFailoverWithCompression and make it extends
> TestReplicationQueueFailover.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira