[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13554529#comment-13554529
]
Ted Yu commented on HBASE-7503:
-------------------------------
{code}
+ * @param regionName the name of the region to get
{code}
'to get' -> 'to get from'
{code}
+ * @param get the client Gets
{code}
parameter name doesn't match: get -> gets
{code}
+ Map<HRegionInfo, List<Get>> sortedGets = new HashMap<HRegionInfo,
List<Get>>();
{code}
Would getsByRegion be better name for the above variable ?
{code}
+ HRegionInfo regionInfo = connection.getRegionLocation(tableName,
get.getRow(), true).getRegionInfo();
{code}
Wrap long line above. The third parameter is true, I think false should be
passed so that locateRegion(name, row) is called:
{code}
return reload? relocateRegion(name, row): locateRegion(name, row);
...
public HRegionLocation locateRegion(final byte [] tableName,
final byte [] row)
throws IOException{
return locateRegion(tableName, row, true, true);
{code}
Note the second last parameter is useCache. The rationale is to reduce query to
.META.
{code}
public Pair<byte[][],byte[][]> getStartEndKeys() throws IOException {
{code}
An alternative is to call the above method and put each Get into corresponding
bucket.
{code}
+ * exists(List) is really a list of get() calls. Just us get().
{code}
typo: us -> use
Putting patch on review board would help reviewers.
> Add exists(List) in HTableInterface to allow multiple parallel exists at one
> time
> ---------------------------------------------------------------------------------
>
> Key: HBASE-7503
> URL: https://issues.apache.org/jira/browse/HBASE-7503
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Marc Spaggiari
> Assignee: Jean-Marc Spaggiari
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch,
> HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
> HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
> HBASE-7503-v5-trunk.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> We need to have a Boolean[] exists(List<Get> gets) throws IOException method
> implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
