[
https://issues.apache.org/jira/browse/HBASE-7503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13555747#comment-13555747
]
Jean-Marc Spaggiari commented on HBASE-7503:
--------------------------------------------
Thanks for the comments/review.
Is the end key = next region start key? If so then yes it should be <. But I
tought the end key of a region was lower than the start key of the next region.
This surprised me I agree because I know we only store the start key for a
region...
I will apply those comments shortly:
qt. Map<Get, Integer> reference = new HashMap<Get, Integer>();
qt. needs better name.
qt. LOG.debug("Failed for gets on region: " + sortedGetEntry.getKey());
qt. warn, like below?
qt. testHTableExists
qt. Misleading name too.
qt. I'd split the test into smaller tests too (approximately on comment
boundaries ) but that's a matter of personal preference.
I will also rename "references".
I'm not sure for the comment about "While mapping..." and "Maybe it's possible
to have array, ..." I will have to read them again to make sure I get the
suggestion correctly.
> Add exists(List) in HTableInterface to allow multiple parallel exists at one
> time
> ---------------------------------------------------------------------------------
>
> Key: HBASE-7503
> URL: https://issues.apache.org/jira/browse/HBASE-7503
> Project: HBase
> Issue Type: Improvement
> Reporter: Jean-Marc Spaggiari
> Assignee: Jean-Marc Spaggiari
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-7503-v0-trunk.patch, HBASE-7503-v1-trunk.patch,
> HBASE-7503-v2-trunk.patch, HBASE-7503-v2-trunk.patch,
> HBASE-7503-v3-trunk.patch, HBASE-7503-v4-trunk.patch,
> HBASE-7503-v5-trunk.patch, HBASE-7503-v7-trunk.patch,
> HBASE-7503-v8-trunk.patch
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> We need to have a Boolean[] exists(List<Get> gets) throws IOException method
> implemented in HTableInterface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
