[ 
https://issues.apache.org/jira/browse/HBASE-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13556694#comment-13556694
 ] 

stack commented on HBASE-7533:
------------------------------

[~enis] Yeah.  Looks like Elliott's scratches but rather than a factory you'd 
just drop the bytes into the Constructor and let the class make sense of it.  
That'd work.

But I'd suggest we do not need a generically extensible system that allows 
adding new payload-bearing exception types (see above where we would want to 
discourage control via exception).

Reading through RegionServer exceptions I see one exception that takes payload, 
RegionServerMoved, so let us just explicitly handle this type beyond the base 
'String' type we already have in rpc.

Do you lot think there could be more?  It would have to be exceptions that were 
not method specific because for these types then we should suggest the method 
response include the exception as an optional response.  So that leaves 
exceptions that could come out of multiple methods or problems the server 
encounters while running.

Chatting w/ Elliott, the base 'String' Exception type is already extensible 
being a protobuf so we could add extra info therein that the client exception 
classes could interpret if able such as how long to hold before retrying (a 
pushback).

Can you lads think of any others?

I'd think that we'd try and keep the spec as narrow as possible (and no 
narrower) so if we could do without having an extensible fancy payload bearing 
exception types system, lets punt.
                
> Write an RPC Specification for 0.96
> -----------------------------------
>
>                 Key: HBASE-7533
>                 URL: https://issues.apache.org/jira/browse/HBASE-7533
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.96.0
>
>         Attachments: 7533_proto_sketch.txt, rpc_spec.txt
>
>
> RPC format is changing for 0.96 to accomodate our protobufing all around.  
> Here is a first cut.  Please shred: 
> https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to