[
https://issues.apache.org/jira/browse/HBASE-7460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557613#comment-13557613
]
Hadoop QA commented on HBASE-7460:
----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12565546/HBASE-7460_2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 42 new
or modified tests.
{color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop
2.0 profile.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces lines longer than
100
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/4092//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4092//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4092//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4092//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4092//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4092//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4092//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/4092//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/4092//console
This message is automatically generated.
> Cleanup client connection layers
> --------------------------------
>
> Key: HBASE-7460
> URL: https://issues.apache.org/jira/browse/HBASE-7460
> Project: HBase
> Issue Type: Improvement
> Components: Client, IPC/RPC
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Fix For: 0.96.0
>
> Attachments: HBASE-7460_2.patch
>
>
> This issue originated from a discussion over in HBASE-7442. We currently
> have a broken abstraction with {{HBaseClient}}, where it is bound to a single
> {{Configuration}} instance at time of construction, but then reused for all
> connections to all clusters. This is combined with multiple, overlapping
> layers of connection caching.
> Going through this code, it seems like we have a lot of mismatch between the
> higher layers and the lower layers, with too much abstraction in between. At
> the lower layers, most of the {{ClientCache}} stuff seems completely unused.
> We currently effectively have an {{HBaseClient}} singleton (for
> {{SecureClient}} as well in 0.92/0.94) in the client code, as I don't see
> anything that calls the constructor or {{RpcEngine.getProxy()}} versions with
> a non-default socket factory. So a lot of the code around this seems like
> built up waste.
> The fact that a single Configuration is fixed in the {{HBaseClient}} seems
> like a broken abstraction as it currently stands. In addition to cluster ID,
> other configuration parameters (max retries, retry sleep) are fixed at time
> of construction. The more I look at the code, the more it looks like the
> {{ClientCache}} and sharing the {{HBaseClient}} instance is an unnecessary
> complication. Why cache the {{HBaseClient}} instances at all? In
> {{HConnectionManager}}, we already have a mapping from {{Configuration}} to
> {{HConnection}}. It seems to me like each {{HConnection(Implementation)}}
> instance should have it's own {{HBaseClient}} instance, doing away with the
> {{ClientCache}} mapping. This would keep each {{HBaseClient}} associated with
> a single cluster/configuration and fix the current breakage from reusing the
> same {{HBaseClient}} against different clusters.
> We need a refactoring of some of the interactions of
> {{HConnection(Implementation)}}, {{HBaseRPC/RpcEngine}}, and {{HBaseClient}}.
> Off hand, we might want to expose a separate {{RpcEngine.getClient()}} method
> that returns a new {{RpcClient}} interface (implemented by {{HBaseClient}})
> and move the {{RpcEngine.getProxy()}}/{{stopProxy()}} implementations into
> the client. So all proxy invocations can go through the same client, without
> requiring the static client cache. I haven't fully thought this through, so I
> could be missing other important aspects. But that approach at least seems
> like a step in the right direction for fixing the client abstractions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
