[
https://issues.apache.org/jira/browse/HBASE-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13557739#comment-13557739
]
stack commented on HBASE-7601:
------------------------------
JM, mind fixing the likes of the below. In hbase codebase, the 'false' gets
curly braces around it.
{code}
12 + if (obj == null || getClass() != obj.getClass())
13 + return false;
{code}
Also, you seem to add some imports though they are not used 'Delayed' and 'Row'.
Is this right in NullComparator?
{code}
16 + public boolean equals(Object obj) {
17 + return obj == null;
18 + }
{code}
Thanks for doing these findbug issues. I'll update our tolerated findbugs
count after this goes in. It is falling fast.
> Fix 8 remaining EQ findbug warnings from hbase-server.
> ------------------------------------------------------
>
> Key: HBASE-7601
> URL: https://issues.apache.org/jira/browse/HBASE-7601
> Project: HBase
> Issue Type: Bug
> Reporter: Jean-Marc Spaggiari
> Assignee: Jean-Marc Spaggiari
> Fix For: 0.96.0
>
> Attachments: HBASE-7601-v0-trunk.patch, HBASE-7601-v1-trunk.patch,
> HBASE-7601-v2-trunk.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
