[ 
https://issues.apache.org/jira/browse/HBASE-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13559285#comment-13559285
 ] 

Devaraj Das commented on HBASE-7571:
------------------------------------

Now you have some company :-)

Overall the patch looks good to me. I wonder though if 
HTableDescriptor.getDefaultValues needs to be removed?

HTableDescriptor.write and readFields have some inconsistency around the 
versions it is writing/reading.. (version number)

admin.rb has a copy-paste problem in the place where the family config is set. 
You call set_descriptor_config passing the htd. I think you meant to pass 
family.
                
> add the notion of per-table or per-column family configuration
> --------------------------------------------------------------
>
>                 Key: HBASE-7571
>                 URL: https://issues.apache.org/jira/browse/HBASE-7571
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HBASE-7571-v0-based-on-HBASE-7563.patch, 
> HBASE-7571-v0-including-HBASE-7563.patch, HBASE-7571-v1.patch
>
>
> Main part of split HBASE-7236.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to