[ 
https://issues.apache.org/jira/browse/HBASE-6816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560507#comment-13560507
 ] 

nkeywal commented on HBASE-6816:
--------------------------------

Installed the patch on unix & windows, seems ok.

I was surprised because the example in the git documentation explicitly states 
binary for png & jpg. So does 
https://github.com/Countly/countly-sdk-android/blob/master/.gitattributes for 
example. So I changed architecture.gif on windows, committed, then read it from 
Linux. I found my changes. So I'm +1 :-).
                
> [WINDOWS] line endings on checkout for .sh files
> ------------------------------------------------
>
>                 Key: HBASE-6816
>                 URL: https://issues.apache.org/jira/browse/HBASE-6816
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>         Attachments: hbase-16_v1.patch, hbase-6816_v1.patch
>
>
> On code checkout from svn or git, we need to ensure that the line endings for 
> .sh files are LF, so that they work with cygwin. This is important for 
> getting src/saveVersion.sh to work. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to