[
https://issues.apache.org/jira/browse/HBASE-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560519#comment-13560519
]
nkeywal commented on HBASE-6829:
--------------------------------
fwiw, TestDefaultCompactSelection works for me on Windows before and after the
patch. While the patch fixes TestCacheOnWriteInSchema. But what's in
TestDefaultCompactSelection makes sense.
There are some unused variable in TestDefaultCompactSelection, but they were
there before the patch:
long tooBig = maxSize + 1;
Path oldLogDir = new Path(basedir, HConstants.HREGION_OLDLOGDIR_NAME);
So +1 from me as well.
> [WINDOWS] Tests should ensure that HLog is closed
> -------------------------------------------------
>
> Key: HBASE-6829
> URL: https://issues.apache.org/jira/browse/HBASE-6829
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.94.3, 0.96.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Labels: windows
> Attachments: hbase-6829_v1-0.94.patch, hbase-6829_v1-trunk.patch,
> hbase-6829_v2-0.94.patch, hbase-6829_v2-trunk.patch,
> hbase-6829_v3-0.94.patch, hbase-6829_v3-trunk.patch,
> hbase-6829_v4-trunk.patch, hbase-6829_v4-trunk.patch
>
>
> TestCacheOnWriteInSchema and TestCompactSelection fails with
> {code}
> java.io.IOException: Target HLog directory already exists:
> ./target/test-data/2d814e66-75d3-4c1b-92c7-a49d9972e8fd/TestCacheOnWriteInSchema/logs
> at org.apache.hadoop.hbase.regionserver.wal.HLog.<init>(HLog.java:385)
> at org.apache.hadoop.hbase.regionserver.wal.HLog.<init>(HLog.java:316)
> at
> org.apache.hadoop.hbase.regionserver.TestCacheOnWriteInSchema.setUp(TestCacheOnWriteInSchema.java:162)
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
