[ 
https://issues.apache.org/jira/browse/HBASE-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13560966#comment-13560966
 ] 

Enis Soztutar commented on HBASE-6832:
--------------------------------------

bq. for EnvironmentEdgeManager, should we not always initialize the 'time' at 
100000 or something like this? I can imagine other piece of code doing minus 
something. Initializing it to something high enough could save us from some 
burden later.
Makes sense. I changed it so that it starts with currentTimeMillis by default. 
bq. For the fix, except this non critical comment above, I'm ok, but I wonder 
if the root issue (strange time counter on windows) won't shows up in 
production. That's another subject, though.
Opened HBASE-6833 for that, although the fix is not that clear at this point. 
                
> [WINDOWS] Tests should use explicit timestamp for Puts, and not rely on 
> implicit RS timing  
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-6832
>                 URL: https://issues.apache.org/jira/browse/HBASE-6832
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.3, 0.96.0
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>              Labels: windows
>         Attachments: hbase-6832_v1-0.94.patch, hbase-6832_v1-trunk.patch, 
> hbase-6832_v4-0.94.patch, hbase-6832_v4-trunk.patch, hbase-6832_v5-trunk.patch
>
>
> TestRegionObserverBypass.testMulti() fails with 
> {code}
> java.lang.AssertionError: expected:<1> but was:<0>
>       at org.junit.Assert.fail(Assert.java:93)
>       at org.junit.Assert.failNotEquals(Assert.java:647)
>       at org.junit.Assert.assertEquals(Assert.java:128)
>       at org.junit.Assert.assertEquals(Assert.java:472)
>       at org.junit.Assert.assertEquals(Assert.java:456)
>       at 
> org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass.checkRowAndDelete(TestRegionObserverBypass.java:173)
>       at 
> org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass.testMulti(TestRegionObserverBypass.java:166)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to