[ 
https://issues.apache.org/jira/browse/HBASE-7382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13561236#comment-13561236
 ] 

Ted Yu commented on HBASE-7382:
-------------------------------

The 3 additional findbugs warnings are the following:
{code}
>   <BugInstance type="HE_EQUALS_USE_HASHCODE" priority="1" abbrev="HE" 
> category="BAD_PRACTICE">
>     <Class 
> classname="org.apache.hadoop.hbase.zookeeper.ZKUtil$ZKUtilOp$CreateAndFailSilent">
...
>   <BugInstance type="HE_EQUALS_USE_HASHCODE" priority="1" abbrev="HE" 
> category="BAD_PRACTICE">
>     <Class 
> classname="org.apache.hadoop.hbase.zookeeper.ZKUtil$ZKUtilOp$DeleteNodeFailSilent">
...
>   <BugInstance type="HE_EQUALS_USE_HASHCODE" priority="1" abbrev="HE" 
> category="BAD_PRACTICE">
>     <Class 
> classname="org.apache.hadoop.hbase.zookeeper.ZKUtil$ZKUtilOp$SetData">
...
{code}
Please refer to newPatchFindbugsWarningshbase-server.xml from PreCommit build 
4150 for details.
                
> Port ZK.multi support from HBASE-6775 to 0.96
> ---------------------------------------------
>
>                 Key: HBASE-7382
>                 URL: https://issues.apache.org/jira/browse/HBASE-7382
>             Project: HBase
>          Issue Type: Bug
>          Components: Zookeeper
>            Reporter: Gregory Chanan
>            Assignee: Himanshu Vashishtha
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: HBASE-7382-trunk.patch
>
>
> HBASE-6775 adds support for ZK.multi ZKUtil and uses it for the 0.92/0.94 
> compatibility fix implemented in HBASE-6710.
> ZK.multi support is most likely useful in 0.96, but since HBASE-6710 is not 
> relevant for 0.96, perhaps we should find another use case first before we 
> port.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to