[ 
https://issues.apache.org/jira/browse/HBASE-7684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563820#comment-13563820
 ] 

Ted Yu commented on HBASE-7684:
-------------------------------

Patch looks good.
If you can show us the NullPointException stack trace, that would be nice.
{code}
-          call.setValue(value);
+         if (call != null) {
{code}
You can see that start of if statement doesn't align with call.setValue() 
statement.

Please use dev-support/hbase_eclipse_formatter.xml from trunk so that the code 
style aligns with guideline.
                
> NullPointerException in SecureClient when Call is cleaned up due to RPC  
> timeout
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-7684
>                 URL: https://issues.apache.org/jira/browse/HBASE-7684
>             Project: HBase
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.94.3
>            Reporter: cuijianwei
>         Attachments: check_call_null_before_set_in_secure_client.diff
>
>
> We find NullPointException when using SecureClient to access hbase. From the 
> source code, we find that receiveResponse() will not check call != null 
> before invoke call.setValue(...)(line 378 and 380 in SecureClient.java). 
> However, as explained in receiveResponse() of HBaseClient, the call may have 
> been cleaned up due to RPC timeout; therefore, it should be better to check 
> call != null before invoke call.setValue(...) in SecureClient

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to