[ https://issues.apache.org/jira/browse/HBASE-7688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13563970#comment-13563970 ]
Ted Yu commented on HBASE-7688: ------------------------------- {code} public ClientProtos.CoprocessorServiceResponse execMasterService(final RpcController controller, final ClientProtos.CoprocessorServiceRequest request) throws ServiceException { try { ServerRpcController execController = new ServerRpcController(); {code} If controller is an instance of ServerRpcController, do we need to create a new instance ? > Master coprocessor RPCs don't propagate exceptions > -------------------------------------------------- > > Key: HBASE-7688 > URL: https://issues.apache.org/jira/browse/HBASE-7688 > Project: HBase > Issue Type: Bug > Components: Protobufs > Affects Versions: 0.96.0 > Reporter: Mike Lewis > Fix For: 0.96.0 > > Attachments: fix-hmaster-rpc-exceptions.patch > > > I was working on some coprocessor tests, and was wondering why exceptions > weren't bubbling up while calling checkFailed on my RpcController. > Turns out, that HMaster's execMasterService seems to be sending the wrong > RpcController (that happens to be null in my case) to the methods. > I have a fix that appears to work, but I am not familiar enough with the code > to know that it's the write one. > Version I am working on has the git sha 9a322b0 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira