[ 
https://issues.apache.org/jira/browse/HBASE-1212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564071#comment-13564071
 ] 

chunhui shen commented on HBASE-1212:
-------------------------------------

We will use sequenceId to sort HFiles, like in compaction.
When merging, there is no overlap between these two files from different 
regions, I think it's ok even if two files have the same sequence ID since we 
don't use it to distingush the files in Store any more 

Patch looks good for me
                
> merge tool expects regions all have different sequence ids
> ----------------------------------------------------------
>
>                 Key: HBASE-1212
>                 URL: https://issues.apache.org/jira/browse/HBASE-1212
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Jean-Marc Spaggiari
>         Attachments: failure.log, HBASE-1212.patch, HBASE-1212-v2.patch, 
> HBASE-1212-v3-trunk.patch
>
>
> Currently merging two regions, the merge tool will compare their sequence 
> ids.  If same, it will decrement one.  It needs to do this because on region 
> open, files are keyed by their sequenceid; if two the same, one will erase 
> the other.
> Well, with the move to the aggregating hfile format, the sequenceid is 
> written when the file is created and its no longer written into an aside file 
> but as metadata on to the end of the file.  Changing the sequenceid is no 
> longer an option.
> This issue is about figuring a solution for the rare case where two store 
> files have same sequence id AND we want to merge the two regions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to