[ 
https://issues.apache.org/jira/browse/HBASE-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564728#comment-13564728
 ] 

Nick Dimiduk commented on HBASE-7690:
-------------------------------------

Technically speaking, this functionality is in HFilePrettyPrinter, not the 
HFile itself. The pretty-printer already replicated two constants from 
StoreFile. I updated those to use the public static final constants as 
appropriate. Perhaps the circular reference is to be avoided? In general 
though, not using the constants exported by another class has a bit of 
code-smell to it.

Please advise.
                
> Improve metadata printing in HFilePrettyPrinter
> -----------------------------------------------
>
>                 Key: HBASE-7690
>                 URL: https://issues.apache.org/jira/browse/HBASE-7690
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile
>            Reporter: Nick Dimiduk
>            Assignee: Nick Dimiduk
>            Priority: Minor
>         Attachments: 0001-HBASE-7690-Improve-printing-of-HFile-metadata.patch
>
>
> The pretty printer could do a better job with metadata. For example:
> {noformat}
> ...
> Fileinfo:
>     BULKLOAD_SOURCE_TASK = attempt_201301272014_0001_r_000000_0
>     BULKLOAD_TIMESTAMP = \x00\x00\x01<\x7FcG\x8E
>     DELETE_FAMILY_COUNT = \x00\x00\x00\x00\x00\x00\x00\x00
>     EARLIEST_PUT_TS = \x00\x00\x01<\x7Fc&F
>     EXCLUDE_FROM_MINOR_COMPACTION = \x00
>     KEY_VALUE_VERSION = \x00\x00\x00\x01
>     MAJOR_COMPACTION_KEY = \xFF
>     MAX_MEMSTORE_TS_KEY = \x00\x00\x00\x00\x00\x00\x00\x00
>     TIMERANGE = 1359346869830....1359346869830
>     hfile.AVG_KEY_LEN = 19
>     hfile.AVG_VALUE_LEN = 2
>     hfile.LASTKEY = \x00\x04row9\x01dc2\x00\x00\x01<\x7Fc&F\x04
> ...
> {noformat}
> May of these fields could be cleaned up to print in human-readable values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to