[ 
https://issues.apache.org/jira/browse/HBASE-2611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564936#comment-13564936
 ] 

Jean-Daniel Cryans commented on HBASE-2611:
-------------------------------------------

Some comments:

bq. LOG.info("Moving " + rsZnode + "'s hlogs to my queue");

This could be changed to say whether it's going to be done atomically or not.

bq. LOG.debug(" The multi list is: " + listOfOps + ", size: " + 
listOfOps.size());

This is going to print a lot of object references... not sure how useful this 
is. Maybe just keep the size?

bq. LOG.info("Atomically moved the dead regionserver logs. ");

With my first comment this becomes redundant and somewhere else it will say 
when the move is done anyway.

bq. LOG.warn("Got exception in copyQueuesFromRSUsingMulti: " + e);

Put the "e" in the second paramater instead of appending it to the string.
                
> Handle RS that fails while processing the failure of another one
> ----------------------------------------------------------------
>
>                 Key: HBASE-2611
>                 URL: https://issues.apache.org/jira/browse/HBASE-2611
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Replication
>            Reporter: Jean-Daniel Cryans
>            Assignee: Himanshu Vashishtha
>            Priority: Critical
>             Fix For: 0.96.0, 0.94.5
>
>         Attachments: 2611-trunk-v3.patch, 2611-v3.patch, 
> HBASE-2611-trunk-v2.patch, HBase-2611-upstream-v1.patch, HBASE-2611-v2.patch
>
>
> HBASE-2223 doesn't manage region servers that fail while doing the transfer 
> of HLogs queues from other region servers that failed. Devise a reliable way 
> to do it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to