[
https://issues.apache.org/jira/browse/HBASE-7533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13564960#comment-13564960
]
Devaraj Das commented on HBASE-7533:
------------------------------------
Looks good overall. I think most of what I was planning to fix in HBASE-5945
has been taken into consideration in this one.
Couple of comments:
1. Why is the callId made a long? Is it for future proofing?
2. The exception handling seems somewhat customized. Maybe it's fine but it
stands out. Will see if I can think of a better approach short of the full
blown exception handling in RPC (which you probably don't like :-) ).
- the special casing of the RegionMovedException
- RemoteWithExtrasException
I ran some RPC tests (TestDelayedRpc, TestProtoBufRpc) with the patch. They
passed. TestPriorityRpc failed. When I replaced isMetaTable calls with
isMetaRegion (as in the earlier code), it passed as well.
Are we breaking this up into two parts - one this, and another for the encoded
data blocks thing?
> Write an RPC Specification for 0.96
> -----------------------------------
>
> Key: HBASE-7533
> URL: https://issues.apache.org/jira/browse/HBASE-7533
> Project: HBase
> Issue Type: Bug
> Reporter: stack
> Assignee: stack
> Fix For: 0.96.0
>
> Attachments: 7533_proto_sketch.txt, rpc_spec3.txt, rpc_spec.txt
>
>
> RPC format is changing for 0.96 to accomodate our protobufing all around.
> Here is a first cut. Please shred:
> https://docs.google.com/document/d/1-1RJMLXzYldmHgKP7M7ynK6euRpucD03fZ603DlZfGI/edit
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
